gh-131178: Add tests for cProfile command-line interface#144918
Open
NekoAsakura wants to merge 1 commit intopython:mainfrom
Open
gh-131178: Add tests for cProfile command-line interface#144918NekoAsakura wants to merge 1 commit intopython:mainfrom
NekoAsakura wants to merge 1 commit intopython:mainfrom
Conversation
The existing TestCommandLine class only had two tests (invalid sort option and __main__ namespace). This expands coverage to exercise all major CLI code paths: - help output (-h/--help) - no arguments (usage + exit code 2) - unknown option (error + exit code 2) - invalid sort option (error + exit code 2) - valid sort options with both -s and --sort forms - output file with both -o and --outfile forms - profiling a script file - profiling a module via -m - nonexistent script file (FileNotFoundError)
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing TestCommandLine class only had two tests (invalid sort option and main namespace). This expands coverage to exercise all major CLI code paths:
help output (-h/--help)
no arguments (usage + exit code 2)
unknown option (error + exit code 2)
invalid sort option (error + exit code 2)
valid sort options with both -s and --sort forms
output file with both -o and --outfile forms
profiling a script file
profiling a module via -m
nonexistent script file (FileNotFoundError)
New tests added
test_help-h/--helpprints usage with correct program nametest_no_argstest_unknown_optiontest_invalid_sort-svalue gives optparse error (strengthened fromassertGreater(rc, 0)toassertEqual(rc, 2))test_valid_sort-sand--sorttest_outfile-o/--outfilewrites non-empty profile datatest_profile_scripttest_profile_module-mflag profiles a library moduletest_nonexistent_scriptFileNotFoundError