GH-130750: Restore quoting of choices in argparse error messages to match documentation and improve clarity#144983
Open
savannahostrowski wants to merge 3 commits intopython:mainfrom
Open
GH-130750: Restore quoting of choices in argparse error messages to match documentation and improve clarity#144983savannahostrowski wants to merge 3 commits intopython:mainfrom
savannahostrowski wants to merge 3 commits intopython:mainfrom
Conversation
sobolevn
approved these changes
Feb 19, 2026
Member
sobolevn
left a comment
There was a problem hiding this comment.
I support explicit quotes, because bar in Python is a variable name, 'bar' is a string. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 66b3922 (gh-117766), argparse was changed to use
str()instead ofrepr()when displaying choices in error messages. This was done to improve StrEnum display, but had the side effect of removing quotes from string choices, making error messages less clear and inconsistent with the documentation.This PR restores quoting and adds special handling for Enum members to display just the quoted value (e.g.,
'red'instead of<Color.RED: 'red'>). This also improves clarity for mixed-type choices (e.g.,1, '2'clearly shows int vs string).