gh-144748: Make PyErr_CheckSignals raise the exception scheduled by PyThreadState_SetAsyncExc#145178
Open
encukou wants to merge 7 commits intopython:mainfrom
Open
gh-144748: Make PyErr_CheckSignals raise the exception scheduled by PyThreadState_SetAsyncExc#145178encukou wants to merge 7 commits intopython:mainfrom
encukou wants to merge 7 commits intopython:mainfrom
Conversation
Member
ZeroIntensity
left a comment
There was a problem hiding this comment.
This looks pretty good. Some non-blocking comments/questions below.
Comment on lines
+1444
to
+1445
| _PyErr_SetNone(tstate, exc); | ||
| Py_DECREF(exc); |
Member
There was a problem hiding this comment.
What happens if exc is an exception instance, rather than a class? Is PyThreadState_SetAsyncExc supposed to support that?
Member
Author
There was a problem hiding this comment.
The usual C error checking message:
SystemError: _PyErr_SetObject: exception InjectedException() is not a BaseException subclass
Supporting instances would be a reasonable feature, but I haven't seen anyone asking for it.
Lib/test/test_threading.py
Outdated
| self.assertEqual(result, 1) | ||
|
|
||
| for _ in support.sleeping_retry(support.SHORT_TIMEOUT): | ||
| signal.pthread_kill(thread.ident, signal.SIGUSR1) |
Member
There was a problem hiding this comment.
It looks like this has trouble on some systems. Looking at other tests, we might need to run this code in a subprocess?
Member
Author
There was a problem hiding this comment.
Checked on a Mac: it's trying to pthread_kill a thread that already exited 🤦
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tstate->async_exc#144748📚 Documentation preview 📚: https://cpython-previews--145178.org.readthedocs.build/