gh-145166: Fix crash in tzinfo.fromutc() when subclass __new__ returns non-datetime#145181
Open
HELLPUSYY666 wants to merge 1 commit intopython:mainfrom
Open
gh-145166: Fix crash in tzinfo.fromutc() when subclass __new__ returns non-datetime#145181HELLPUSYY666 wants to merge 1 commit intopython:mainfrom
HELLPUSYY666 wants to merge 1 commit intopython:mainfrom
Conversation
…returns non-datetime
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
tzinfo_fromutc(), the result ofadd_datetime_timedelta()is castto
PyDateTime_DateTime*without a type check. If adatetimesubclass__new__returns a non-datetime object, the interpreter crashes withSIGABRTdue to out-of-bounds memory reads insidenormalize_y_m_d().Fix
PyDateTime_Check()after both calls toadd_datetime_timedelta()in
Modules/_datetimemodule.c- raisesTypeErrorinstead of crashingisinstance()checks inLib/_pydatetime.pyLib/test/datetimetester.pyTesting
Regression test passes for both
TestDateTimeTZ_PureandTestDateTimeTZ_Fast.