gh-142414: Make value, not identity, matter for UNBOUND* objects#145184
Open
encukou wants to merge 2 commits intopython:mainfrom
Open
gh-142414: Make value, not identity, matter for UNBOUND* objects#145184encukou wants to merge 2 commits intopython:mainfrom
encukou wants to merge 2 commits intopython:mainfrom
Conversation
Co-Authored-By: Kir Chou <note351@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realize there's a pile of PRs for the issue already,
I couldn't find a reason why the singletons (
UNBOUND,UNBOUND_ERROR,UNBOUND_REMOVE) need to be singletons. Each is essentially a name for the underlying int (used in the C layer); plusUNBOUNDdoubles as the replacement value but that's not the issue here.I also couldn't find a reason to have different
UNBOUNDobjects in different modules.This converts them to a normal class, and compares by value rather than identity.
./python -m test test_interpreters test_structfails with: KeyError: concurrent.interpreters._queues.UNBOUND #142414