Skip to content

Fix "lazy from (...) import (...)" tests #145213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FFY00 merged 1 commit into from
Feb 25, 2026
Merged

Fix "lazy from (...) import (...)" tests #145213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Lib/test/test_import/data/lazy_imports/global_filter_from.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import importlib
import sys

def filter(module_name, imported_name, from_list):
assert module_name == __name__
assert imported_name == "test.test_import.data.lazy_imports.basic2"
assert from_list == ['f']
assert from_list == ('f',)
return False

importlib.set_lazy_imports(None, filter)
sys.set_lazy_imports_filter(filter)

lazy from import test.test_import.data.lazy_imports.basic2 import f
lazy from test.test_import.data.lazy_imports.basic2 import f
9 changes: 5 additions & 4 deletions Lib/test/test_import/data/lazy_imports/global_filter_from_true.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
import importlib
import sys

def filter(module_name, imported_name, from_list):
assert module_name == __name__
assert imported_name == "test.test_import.data.lazy_imports.basic2"
assert from_list == ['f']
assert from_list == ('f',)
return True

importlib.set_lazy_imports(None, filter)
sys.set_lazy_imports("normal")
sys.set_lazy_imports_filter(filter)

lazy from import test.test_import.data.lazy_imports.basic2 import f
lazy from test.test_import.data.lazy_imports.basic2 import f
4 changes: 2 additions & 2 deletions Lib/test/test_import/test_lazy_imports.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,12 +119,12 @@ def test_global_filter_true(self):

def test_global_filter_from(self):
"""Filter should work with 'from' imports."""
import test.test_import.data.lazy_imports.global_filter
import test.test_import.data.lazy_imports.global_filter_from
self.assertIn("test.test_import.data.lazy_imports.basic2", sys.modules)

def test_global_filter_from_true(self):
"""Filter returning True should allow lazy 'from' imports."""
import test.test_import.data.lazy_imports.global_filter_true
import test.test_import.data.lazy_imports.global_filter_from_true
self.assertNotIn("test.test_import.data.lazy_imports.basic2", sys.modules)


Expand Down
Loading