Fix compileall in lazy imports test data with bad syntax#145221
Merged
FFY00 merged 2 commits intopython:mainfrom Feb 25, 2026
Merged
Fix compileall in lazy imports test data with bad syntax#145221FFY00 merged 2 commits intopython:mainfrom
FFY00 merged 2 commits intopython:mainfrom
Conversation
Signed-off-by: Filipe Laíns <lains@riseup.net>
pablogsal
approved these changes
Feb 25, 2026
Member
|
Thanks @FFY00 🙏 |
Signed-off-by: Filipe Laíns <lains@riseup.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the compileall call of
libinstallis generating some errors.global_filter_fromandglobal_filter_from_trueare not meant to have a syntax error (see GH-145213), but the rest of the files are.This PR moves them to a
badsyntaxdirectory, so that they match the ignore pattern in the compileall call.It seemed better than adding
badsyntaxto the file name.