Skip to content

Fix compileall in lazy imports test data with bad syntax#145221

Merged
FFY00 merged 2 commits intopython:mainfrom
FFY00:fix-compileall-test_lazy_imports
Feb 25, 2026
Merged

Fix compileall in lazy imports test data with bad syntax#145221
FFY00 merged 2 commits intopython:mainfrom
FFY00:fix-compileall-test_lazy_imports

Conversation

@FFY00
Copy link
Member

@FFY00 FFY00 commented Feb 25, 2026

Currently, the compileall call of libinstall is generating some errors.

$ DESTDIR=destdir make libinstall
(..)
PYTHONPATH=destdir/usr/local/lib/python3.15t  \
	./python -E -Wi destdir/usr/local/lib/python3.15t/compileall.py \
	-o 0 -o 1 -o 2 -j0 -d /usr/local/lib/python3.15t -f \
	-x 'bad_coding|badsyntax|site-packages' \
	destdir/usr/local/lib/python3.15t
(..)
Compiling 'destdir/usr/local/lib/python3.15t/test/test_import/data/lazy_imports/global_filter_from.py'...
***   File "/usr/local/lib/python3.15t/test/test_import/data/lazy_imports/global_filter_from.py", line 11
    lazy from import test.test_import.data.lazy_imports.basic2 import f
              ^^^^^^
SyntaxError: invalid syntax

Compiling 'destdir/usr/local/lib/python3.15t/test/test_import/data/lazy_imports/global_filter_from_true.py'...
***   File "/usr/local/lib/python3.15t/test/test_import/data/lazy_imports/global_filter_from_true.py", line 11
    lazy from import test.test_import.data.lazy_imports.basic2 import f
              ^^^^^^
SyntaxError: invalid syntax
(..)
Compiling 'destdir/usr/local/lib/python3.15t/test/test_import/data/lazy_imports/lazy_class_body.py'...
***   File "/usr/local/lib/python3.15t/test/test_import/data/lazy_imports/lazy_class_body.py", line 3
SyntaxError: lazy import not allowed inside classes

Compiling 'destdir/usr/local/lib/python3.15t/test/test_import/data/lazy_imports/lazy_compat_from.py'...
Compiling 'destdir/usr/local/lib/python3.15t/test/test_import/data/lazy_imports/lazy_future_import.py'...
***   File "/usr/local/lib/python3.15t/test/test_import/data/lazy_imports/lazy_future_import.py", line 1
    lazy from __future__ import annotations
    ^^^^
SyntaxError: lazy from __future__ import is not allowed

Compiling 'destdir/usr/local/lib/python3.15t/test/test_import/data/lazy_imports/lazy_get_value.py'...
Compiling 'destdir/usr/local/lib/python3.15t/test/test_import/data/lazy_imports/lazy_try_except_from_star.py'...
***   File "/usr/local/lib/python3.15t/test/test_import/data/lazy_imports/lazy_try_except_from_star.py", line 1
SyntaxError: lazy from ... import * is not allowed
(...)
Compiling 'destdir/usr/local/lib/python3.15t/test/test_import/data/lazy_imports/lazy_import_func.py'...
***   File "/usr/local/lib/python3.15t/test/test_import/data/lazy_imports/lazy_import_func.py", line 2
SyntaxError: lazy import not allowed inside functions

Compiling 'destdir/usr/local/lib/python3.15t/test/test_import/data/lazy_imports/lazy_import_pkg.py'...
Compiling 'destdir/usr/local/lib/python3.15t/test/test_import/data/lazy_imports/lazy_try_except.py'...
***   File "/usr/local/lib/python3.15t/test/test_import/data/lazy_imports/lazy_try_except.py", line 2
SyntaxError: lazy import not allowed inside try/except blocks

Compiling 'destdir/usr/local/lib/python3.15t/test/test_import/data/lazy_imports/lazy_try_except_from.py'...
***   File "/usr/local/lib/python3.15t/test/test_import/data/lazy_imports/lazy_try_except_from.py", line 2
SyntaxError: lazy from ... import not allowed inside try/except blocks
(...)
make: [Makefile:2974: libinstall] Error 1 (ignored)

global_filter_from and global_filter_from_true are not meant to have a syntax error (see GH-145213), but the rest of the files are.

This PR moves them to a badsyntax directory, so that they match the ignore pattern in the compileall call.
It seemed better than adding badsyntax to the file name.

Signed-off-by: Filipe Laíns <lains@riseup.net>
@pablogsal
Copy link
Member

Thanks @FFY00 🙏

Signed-off-by: Filipe Laíns <lains@riseup.net>
@FFY00 FFY00 enabled auto-merge (squash) February 25, 2026 15:57
@FFY00 FFY00 merged commit 56b7dc4 into python:main Feb 25, 2026
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants