Skip to content

gh-145228: Increase performance of _config_dict_get_bool(PyObject *dict, const char *name, int *p_flag) by removing unused PY_DECREF(item) #145229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benediktjohannes wants to merge 2 commits into from
+2 −1
Closed

gh-145228: Increase performance of _config_dict_get_bool(PyObject *dict, const char *name, int *p_flag) by removing unused PY_DECREF(item) #145229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c7f7aa
Increase performance of _config_dict_get_bool(PyObject *dict, const c…
benediktjohannes Feb 25, 2026
a7f591c
📜🤖 Added by blurb_it.
blurb-it[bot] Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Core_and_Builtins/2026-02-25-17-25-36.gh-issue-145228.bM5lo-.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
The function ``_config_dict_get_bool()`` in :file:`Python/interpconfig.c` has been optimized to avoid unnecessary reference count decrements on boolean results.
Patch by Benedikt Johannes.
1 change: 0 additions & 1 deletion Python/interpconfig.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,6 @@ _config_dict_get_bool(PyObject *dict, const char *name, int *p_flag)
config_dict_invalid_type(name);
return -1;
}
Py_DECREF(item);
*p_flag = flag;
return 0;
}
Expand Down
Loading