gh-145261: multiprocessing.shared_memory: fix ShareableList corruption for multi-byte strings and null bytes#145266
Open
zetzschest wants to merge 2 commits intopython:mainfrom
Open
Conversation
…and bytes with trailing nulls
ShareableList had two bugs:
1. Used character count len(item) instead of byte count
len(item.encode('utf-8')) for string slot allocation, causing
UnicodeDecodeError with multi-byte UTF-8 characters.
2. Used rstrip(b'\x00') to recover bytes values, which stripped
legitimate trailing null bytes.
Fix uses UTF-8 byte length for string allocation and stores the actual
byte length in the format metadata for bytes values, so retrieval reads
exactly the right number of bytes without needing rstrip.
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
ShareableListhas two issues:len(item)(character count) for string slot allocation instead oflen(item.encode('utf-8'))(byte count), causingUnicodeDecodeErrorwith multi-byte UTF-8 characters.rstrip(b'\x00')to recover bytes values, which strips legitimate trailing null bytes.Reproducer
Fix
Use
len(item.encode('utf-8'))for string slot allocation. For bytes, store the actual byte length in the format metadata so retrieval reads exactly the right number of bytes without needingrstrip(b'\x00').Test updates
Two assertions in
test_shared_memory_ShareableList_basicsneeded adjustments since they were based on the previous behavior:bytesvalues.