gh-145307: Defer loading psapi.dll until ctypes.util.dllist() is called.#145308
Open
zooba wants to merge 3 commits intopython:mainfrom
Open
gh-145307: Defer loading psapi.dll until ctypes.util.dllist() is called.#145308zooba wants to merge 3 commits intopython:mainfrom
zooba wants to merge 3 commits intopython:mainfrom
Conversation
Member
Author
|
That Android error appears to be network issues (accessing something off of GitHub), so it's not a problem with the PR. If it's a required check now, we can just retrigger it once the rest are done. |
Member
Author
|
As expected, no other issues. So this is ready to merge if anyone wants to jump in with a review/comment (I'll leave it for a few days first, this is basically just a low priority perf/hardening measure, but it's an important good practice for us to follow to avoid adding high priority ones.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.