Use reusable-docs.yml in documentation-links#145346
Use reusable-docs.yml in documentation-links#145346KowalskiThomas wants to merge 2 commits intopython:mainfrom
reusable-docs.yml in documentation-links#145346Conversation
This comment was marked as resolved.
This comment was marked as resolved.
| paths: | ||
| - 'Doc/**' | ||
| - '.github/workflows/doc.yml' | ||
| - '.github/workflows/reusable-docs.yml' |
There was a problem hiding this comment.
This looks wrong. I imagine this was meant to be
| - '.github/workflows/reusable-docs.yml' | |
| - '.github/workflows/documentation-links.yml' |
It'd be useful to do some Git archaelogy to learn the original motivation, perhaps.
There was a problem hiding this comment.
OTOH, maybe it's okay to have both:
| - '.github/workflows/reusable-docs.yml' | |
| - '.github/workflows/reusable-docs.yml' | |
| - '.github/workflows/documentation-links.yml' |
Or use the change detection script that the main integrated workflow relies on (this might be an overkill).
There was a problem hiding this comment.
Thanks! I'll look into it and get back to you :)
There was a problem hiding this comment.
For context, the pattern of listing paths used to list the workflow itself so that it'd run if the automation itself changed in a PR.
There was a problem hiding this comment.
This looks wrong. I imagine this was meant to be ...
Do you mean the original version or my change? I made the change I made because that's what doc.yml was renamed to, but indeed it seems more usual/useful to make the workflow definition depend on changes on itself... I added it.
There was a problem hiding this comment.
I'll also do the archeology you mentioned, just in case there's something we're missing here :)
What is this?
Currently, the
documentation-linksrefers todoc.ymlwhich doesn't exist. I suspect the correct file to reference isreusable-docs.yml, based on just looking at commit history fordoc.ymland seeing 88d14da.Note I didn't add neither a GitHub Issue number nor a News entry as I don't think this warrants either, but feel free to tell me if I should.