Skip to content

Use reusable-docs.yml in documentation-links #145346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
KowalskiThomas wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −1
Draft

Use reusable-docs.yml in documentation-links #145346

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec0dd33
Use reusable-docs.yml in documentation-links
KowalskiThomas Feb 28, 2026
d42f93e
ci: add documentation-links.yml
KowalskiThomas Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/documentation-links.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ on:
- opened
paths:
- 'Doc/**'
- '.github/workflows/doc.yml'
- '.github/workflows/documentation-links.sh'
- '.github/workflows/reusable-docs.yml'
Copy link
Member

@webknjaz webknjaz Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks wrong. I imagine this was meant to be

Suggested change
- '.github/workflows/reusable-docs.yml'
- '.github/workflows/documentation-links.yml'

It'd be useful to do some Git archaelogy to learn the original motivation, perhaps.

Copy link
Member

@webknjaz webknjaz Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OTOH, maybe it's okay to have both:

Suggested change
- '.github/workflows/reusable-docs.yml'
- '.github/workflows/reusable-docs.yml'
- '.github/workflows/documentation-links.yml'

Or use the change detection script that the main integrated workflow relies on (this might be an overkill).

Copy link
Contributor Author

@KowalskiThomas KowalskiThomas Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll look into it and get back to you :)

Copy link
Member

@webknjaz webknjaz Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For context, the pattern of listing paths used to list the workflow itself so that it'd run if the automation itself changed in a PR.

Copy link
Contributor Author

@KowalskiThomas KowalskiThomas Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks wrong. I imagine this was meant to be ...

Do you mean the original version or my change? I made the change I made because that's what doc.yml was renamed to, but indeed it seems more usual/useful to make the workflow definition depend on changes on itself... I added it.

Copy link
Contributor Author

@KowalskiThomas KowalskiThomas Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll also do the archeology you mentioned, just in case there's something we're missing here :)


concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
Expand Down
Loading