Skip to content

gh-145349: Do not install ccache#145350

Open
KowalskiThomas wants to merge 1 commit intopython:mainfrom
KowalskiThomas:kowalski/gh-145349-do-not-add-ccache-to-path
Open

gh-145349: Do not install ccache#145350
KowalskiThomas wants to merge 1 commit intopython:mainfrom
KowalskiThomas:kowalski/gh-145349-do-not-add-ccache-to-path

Conversation

@KowalskiThomas
Copy link

@KowalskiThomas KowalskiThomas commented Feb 28, 2026

What is this PR?

Initial work on GH-145349. Still need to confirm it's OK and whatnot.

@bedevere-app bedevere-app bot mentioned this pull request Feb 28, 2026
Open
@bedevere-app

This comment was marked as resolved.

Sign in to view
@KowalskiThomas KowalskiThomas changed the title gh-145349: Do not add ccache to PATH gh-145349: Do not install ccache Feb 28, 2026
@hugovk hugovk added skip news infra CI, GitHub Actions, buildbots, Dependabot, etc. labels Feb 28, 2026
@webknjaz webknjaz requested a review from gpshead February 28, 2026 10:14
@webknjaz
Copy link
Member

webknjaz commented Feb 28, 2026

@gpshead FYI this seems to conflict with your #127376.

hugovk
hugovk approved these changes Feb 28, 2026
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR removes unnecessary overhead 👍

sccache was proposed (#127376) before we ceasing saving the caches (#139596), so at that time, we were re-using caches.

But I don't think it matters whether we use ccache or sccache, if we're just going to throw away the caches :)

If we do reintroduce caching (via ccache or sccache or something else) then we should also retain the caches between runs, but that can be handled in that PR.

@hugovk hugovk added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Feb 28, 2026
@KowalskiThomas KowalskiThomas marked this pull request as ready for review February 28, 2026 13:23
@KowalskiThomas
Copy link
Author

KowalskiThomas commented Feb 28, 2026

@hugovk I see you added awaiting merge but it seems like putting the PR out of Draft state into Open made the bot remove awaiting merge and add await review back -- is it because I need to get a review from the other listed people?

@hugovk
Copy link
Member

hugovk commented Feb 28, 2026

I think it's because the Bedevere bot resets back to an initial state:

https://github.com/python/bedevere#pr-state-machine

I'll just approve it again, but will wait for other input before merging :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes

@gpshead gpshead Awaiting requested review from gpshead

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

Assignees

No one assigned

Labels

awaiting merge infra CI, GitHub Actions, buildbots, Dependabot, etc. needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KowalskiThomas @webknjaz @hugovk