Skip to content

gh-145376: Fix various reference leaks objects and modules #145385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eendebakpt wants to merge 5 commits into
base: main
Choose a base branch
from
+8 −2
Open

gh-145376: Fix various reference leaks objects and modules #145385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f708b03
Fix reference leak in listiter_reduce_general
eendebakpt Mar 1, 2026
551a741
Fix reference leak in increment_longindex_lock_held
eendebakpt Mar 1, 2026
7015ae6
fix reference leak in count_nextlong
eendebakpt Mar 1, 2026
c02d2db
fix reference leak in count_nextlong
eendebakpt Mar 1, 2026
ff7709c
📜🤖 Added by blurb_it.
blurb-it[bot] Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core_and_Builtins/2026-03-01-10-15-06.gh-issue-145376.lG5u1a.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix reference leaks in various unusual error scenarios.
4 changes: 3 additions & 1 deletion Modules/itertoolsmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3538,8 +3538,10 @@ count_nextlong(countobject *lz)
if (long_cnt == NULL) {
/* Switch to slow_mode */
long_cnt = PyLong_FromSsize_t(PY_SSIZE_T_MAX);
if (long_cnt == NULL)
if (long_cnt == NULL) {
return NULL;
}
lz->long_cnt = long_cnt;
}
assert(lz->cnt == PY_SSIZE_T_MAX && long_cnt != NULL);

Expand Down
1 change: 1 addition & 0 deletions Objects/enumobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,7 @@ increment_longindex_lock_held(enumobject *en)
if (next_index == NULL) {
return NULL;
}
en->en_longindex = next_index;
}
assert(next_index != NULL);
PyObject *stepped_up = PyNumber_Add(next_index, en->one);
Expand Down
4 changes: 3 additions & 1 deletion Objects/listobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4270,7 +4270,9 @@ listiter_reduce_general(void *_it, int forward)
}
/* empty iterator, create an empty list */
list = PyList_New(0);
if (list == NULL)
if (list == NULL) {
Py_DECREF(iter);
return NULL;
}
return Py_BuildValue("N(N)", iter, list);
}
Loading