gh-145335: Fix crash when passing -1 as fd in os.pathconf#145390
Open
aisk wants to merge 2 commits intopython:mainfrom
Open
gh-145335: Fix crash when passing -1 as fd in os.pathconf#145390aisk wants to merge 2 commits intopython:mainfrom
aisk wants to merge 2 commits intopython:mainfrom
Conversation
picnixz
reviewed
Mar 1, 2026
| static bool | ||
| path_is_fd(const path_t *path) | ||
| { | ||
| return path->allow_fd && path->object != NULL && PyIndex_Check(path->object); |
Member
There was a problem hiding this comment.
Is the problem really with the check or with is it with the converter?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently test whether
path_t.fdis -1 to decide if the argument should be treated as an fd or as a path, and then callfpathconf()orpathconf()according to it.In the original issue, we passing -1 caused the code incorrectly treats the argument as a real path. But,
path->narrowis NULL, so callingpathconf()on it will crash the interpreter.This change adds a helper that checks whether the original argument is index-like to determine if it's an fd, so we can correctly the behavior and avoid the crash.
There are other
osfunctions that acceptpath_tand may have the same issue. Since that is outside the scope of the original issue, I think we should fix those in a separate PR.os.pathconf(-1, 1)#145335