gh-145413: Fix nested attribute suggestions executing property code#145414
Open
Hiumee wants to merge 3 commits intopython:mainfrom
Open
gh-145413: Fix nested attribute suggestions executing property code#145414Hiumee wants to merge 3 commits intopython:mainfrom
Hiumee wants to merge 3 commits intopython:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the code of
_check_for_nested_attributeto check properties without triggering their code. This approach will still suggest themChanged a test case to look for side effects and changed some contradictory comments
Updated the news section code to include imports so the code can be tested out of the box
Example
Output
It doesn't reach the print statement at all
📚 Documentation preview 📚: https://cpython-previews--145414.org.readthedocs.build/