Skip to content

[3.10] gh-145455: Constrain setuptools to a version with pkg_resources#145456

Open
encukou wants to merge 1 commit intopython:3.10from
encukou:constrain-setuptools
Open

[3.10] gh-145455: Constrain setuptools to a version with pkg_resources#145456
encukou wants to merge 1 commit intopython:3.10from
encukou:constrain-setuptools

Conversation

@encukou
Copy link
Member

@encukou encukou commented Mar 3, 2026 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Mar 3, 2026
Open
hugovk
hugovk approved these changes Mar 3, 2026
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@encukou encukou requested a review from pablogsal March 3, 2026 12:15
StanFromIreland
StanFromIreland reviewed Mar 3, 2026
View reviewed changes
Copy link
Member

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this not achieved by #144781?

@encukou
Copy link
Member Author

encukou commented Mar 4, 2026

Good point! I did miss the issue-less PR.

But, if I'm reading things correctly, docsbuild-scripts don't use make venv; they use Doc/requirements.txt (which includes -c constraints.txt). So, the #144781 change is good to have (we won't upgrade setuptools only to downgrade it), but we still need this one.
(Maybe make venv could skip preinstalling setuptools altogether, but that's an unnecessary change, so, not in 3.10.)

@hugovk
Copy link
Member

hugovk commented Mar 4, 2026

But, if I'm reading things correctly, docsbuild-scripts don't use make venv; they use Doc/requirements.txt (which includes -c constraints.txt).

That's a link to release-tools, not docsbuild-scripts, but yes, release-tools installs from Doc/requirements.txt 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIreland StanFromIreland StanFromIreland left review comments

@hugovk hugovk hugovk approved these changes

@pablogsal pablogsal Awaiting requested review from pablogsal

Assignees

No one assigned

Labels

awaiting merge skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@encukou @hugovk @StanFromIreland