gh-145376: Fix refleak and null pointer deref in unusual error path of datetime module#145476
Open
eendebakpt wants to merge 3 commits intopython:mainfrom
Open
gh-145376: Fix refleak and null pointer deref in unusual error path of datetime module#145476eendebakpt wants to merge 3 commits intopython:mainfrom
eendebakpt wants to merge 3 commits intopython:mainfrom
Conversation
Member
StanFromIreland
left a comment
There was a problem hiding this comment.
I think this should get a news entry.
Contributor
Author
Added the news entry, although I think we can skip it since the changes are only in very rare paths. |
sergey-miryanov
approved these changes
Mar 4, 2026
Member
That's my assesment too. It's technically a user-visible change, but that user needs to squint really hard. |
vstinner
reviewed
Mar 4, 2026
Comment on lines
6911
to
6912
| PyErr_Format(PyExc_TypeError, "utcoffset() returned %.200s," | ||
| " expected timedelta or None", Py_TYPE(offset)->tp_name); |
Member
There was a problem hiding this comment.
While we are here, you can use %T which is safer and provides more accurate representation:
Suggested change
| PyErr_Format(PyExc_TypeError, "utcoffset() returned %.200s," | |
| " expected timedelta or None", Py_TYPE(offset)->tp_name); | |
| PyErr_Format(PyExc_TypeError, "utcoffset() returned %T," | |
| " expected timedelta or None", offset); |
| @@ -0,0 +1 @@ | |||
| Fix refleak and null pointer deref in unusual error path of :mod:`datetime`. | |||
Member
There was a problem hiding this comment.
Please remove it, users should not be impacted by this change. The error case is very unlikely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.