gh-145524: Update comment for TypeVar S in typing.rst#145525
Open
hyperkai wants to merge 1 commit intopython:mainfrom
Open
gh-145524: Update comment for TypeVar S in typing.rst#145525hyperkai wants to merge 1 commit intopython:mainfrom
hyperkai wants to merge 1 commit intopython:mainfrom
Conversation
Clarified the comment for type variable S to specify it can be str or any subtype of str.
AlexWaygood
approved these changes
Mar 5, 2026
Member
AlexWaygood
left a comment
There was a problem hiding this comment.
The existing text is correct, since str is a subtype of str -- "any subtype of str" includes str itself. But I agree that not all users will necessarily be aware of that, so the edit does seem to make things clearer to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #145524
boundparameter oftyping.TypeVaraccepts should be explained more clearly #145524📚 Documentation preview 📚: https://cpython-previews--145525.org.readthedocs.build/