Skip to content

gh-94523: Detect file if modified at local disk and prompt to ask refresh #145625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
znsoooo wants to merge 4 commits into
base: main
Choose a base branch
from
Open

gh-94523: Detect file if modified at local disk and prompt to ask refresh #145625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
302cf26
Feat: Detect file if modified at local disk and prompt to ask refresh
znsoooo Mar 7, 2026
c37c162
Add NEWS
znsoooo Mar 7, 2026
c60cad5
Merge branch 'upstream' into dev-reload
znsoooo Mar 7, 2026
419546f
Merge branch 'main' into dev-reload
znsoooo Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions Lib/idlelib/editor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,9 @@ def __init__(self, flist=None, filename=None, key=None, root=None):
else:
self.update_menu_state('options', '*ine*umbers', 'disabled')

self.mtime = self.last_mtime()
text_frame.bind('<FocusIn>', self.focus_in_event)

def handle_winconfig(self, event=None):
self.set_width()

Expand Down Expand Up @@ -1027,6 +1030,8 @@ def get_saved(self):

def set_saved(self, flag):
self.undo.set_saved(flag)
if flag:
self.mtime = self.last_mtime()

def reset_undo(self):
self.undo.reset_undo()
Expand Down Expand Up @@ -1112,6 +1117,21 @@ def _close(self):
# unless override: unregister from flist, terminate if last window
self.close_hook()

def last_mtime(self):
file = self.io.filename
return os.path.getmtime(file) if file else 0

def focus_in_event(self, event):
mtime = self.last_mtime()
if self.mtime != mtime:
self.mtime = mtime
if self. askyesno(
'Reload', '"%s"\n\nThis script has been modified by another program.'
'\nDo you want to reload it?' % self.io.filename, parent=self.text):
self.io.loadfile(self.io.filename)
else:
self.set_saved(False)

def load_extensions(self):
self.extensions = {}
self.load_standard_extensions()
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/IDLE/2026-03-07-20-47-40.gh-issue-94523.dq7m2k.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Detect file if modified at local disk and prompt to ask refresh. Patch by
Shixian Li.
Loading