gh-145410: Fix sysconfig.get_platform() on Windows when sys.version is truncated#145635
Open
04cb wants to merge 1 commit intopython:mainfrom
Open
gh-145410: Fix sysconfig.get_platform() on Windows when sys.version is truncated#14563504cb wants to merge 1 commit intopython:mainfrom
04cb wants to merge 1 commit intopython:mainfrom
Conversation
The function was checking for 'amd64' in sys.version to detect 64-bit Windows, but sys.version is truncated at a fixed width and may not contain the architecture marker when the compiler version string is long. Use platform.machine() instead, which reliably returns the machine architecture on Windows regardless of the sys.version content. Fixes python#145410
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
All commit authors signed the Contributor License Agreement. |
Member
|
Quoting @zooba from the issue #145410 (comment)
I also don't think this is the way to go. Furthermore, CI hints that there are problems to solve ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #145410
The function was checking for 'amd64' in sys.version to detect 64-bit
Windows, but sys.version is truncated at a fixed width and may not
contain the architecture marker when the compiler version string is long.
Use platform.machine() instead, which reliably returns the machine
architecture on Windows regardless of the sys.version content.