Skip to content

gh-145754: Update signature retrieval in unittest.mock to use forwardref annotation format#145756

Merged
JelleZijlstra merged 8 commits intopython:mainfrom
mschoettle:patch-1
Mar 20, 2026
Merged

gh-145754: Update signature retrieval in unittest.mock to use forwardref annotation format#145756
JelleZijlstra merged 8 commits intopython:mainfrom
mschoettle:patch-1

Conversation

@mschoettle
Copy link
Contributor

@mschoettle mschoettle commented Mar 10, 2026 •
edited
Loading

Uses annotation format FORWARDREF instead of the default VALUE when calling inspect.signature.
STRING also seems to work but affects existing tests that check the signature.

Closes #145754

@bedevere-app
Copy link

bedevere-app bot commented Mar 10, 2026

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app bedevere-app bot mentioned this pull request Mar 10, 2026
Closed
@mschoettle mschoettle changed the title gh-145754: Update signature retrieval in unittest.mock to use string annotation format gh-145754: Update signature retrieval in unittest.mock to use forwardref annotation format Mar 10, 2026
@JelleZijlstra
Copy link
Member

JelleZijlstra commented Mar 10, 2026

This change looks right to me, please add a unit test and we'll hopefully get it merged!

@JelleZijlstra JelleZijlstra added the needs backport to 3.14 bugs and security fixes label Mar 10, 2026
@mschoettle mschoettle marked this pull request as ready for review March 10, 2026 16:53
@mschoettle mschoettle requested a review from cjw296 as a code owner March 10, 2026 16:53
@epenet epenet mentioned this pull request Mar 11, 2026
Closed
23 tasks
@emontnemery emontnemery mentioned this pull request Mar 11, 2026
Closed
21 tasks
@mschoettle
Copy link
Contributor Author

mschoettle commented Mar 18, 2026

This change looks right to me, please add a unit test and we'll hopefully get it merged!

Thanks, @JelleZijlstra! I added a unit test. Are you able to review it or does it require @cjw296 as the code owner?

JelleZijlstra
JelleZijlstra reviewed Mar 19, 2026
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, looks like I never submitted this review.

I am comfortable merging this once I'm happy with the code.

mschoettle and others added 3 commits March 19, 2026 12:15
@JelleZijlstra JelleZijlstra merged commit d357a7d into python:main Mar 20, 2026
47 checks passed
@miss-islington-app
Copy link

miss-islington-app bot commented Mar 20, 2026

Thanks @mschoettle for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 20, 2026
@mschoettle @miss-islington
pythongh-145754: Update signature retrieval in unittest.mock to use f…
186b50d 
…orwardref annotation format (pythonGH-145756)

(cherry picked from commit d357a7dbf38868844415ec1d5df80379ea5a2326)

Co-authored-by: Matthias Schoettle <git@mattsch.com>
@bedevere-app
Copy link

bedevere-app bot commented Mar 20, 2026

GH-146191 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Mar 20, 2026
@bedevere-bot
Copy link

bedevere-bot commented Mar 20, 2026

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86 Debian Non-Debug with X 3.x (no tier) has failed when building commit d357a7d.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1245/builds/7793) and take a look at the build logs.
  4. Check if the failure is related to this commit (d357a7d) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1245/builds/7793

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File �[35m"/buildbot/buildarea/3.x.ware-debian-x86.nondebug/build/Lib/contextlib.py"�[0m, line �[35m85�[0m, in �[35minner�[0m
    return func(*args, **kwds)
  File �[35m"/buildbot/buildarea/3.x.ware-debian-x86.nondebug/build/Lib/test/_test_multiprocessing.py"�[0m, line �[35m597�[0m, in �[35mtest_interrupt�[0m
    exitcode = self._kill_process(multiprocessing.Process.interrupt)
  File �[35m"/buildbot/buildarea/3.x.ware-debian-x86.nondebug/build/Lib/contextlib.py"�[0m, line �[35m85�[0m, in �[35minner�[0m
    return func(*args, **kwds)
  File �[35m"/buildbot/buildarea/3.x.ware-debian-x86.nondebug/build/Lib/test/_test_multiprocessing.py"�[0m, line �[35m578�[0m, in �[35m_kill_process�[0m
    self.assertEqual(�[31mjoin�[0m�[1;31m()�[0m, None)
                     �[31m~~~~�[0m�[1;31m^^�[0m
  File �[35m"/buildbot/buildarea/3.x.ware-debian-x86.nondebug/build/Lib/test/_test_multiprocessing.py"�[0m, line �[35m251�[0m, in �[35m__call__�[0m
    return �[31mself.func�[0m�[1;31m(*args, **kwds)�[0m
           �[31m~~~~~~~~~�[0m�[1;31m^^^^^^^^^^^^^^^�[0m
  File �[35m"/buildbot/buildarea/3.x.ware-debian-x86.nondebug/build/Lib/multiprocessing/process.py"�[0m, line �[35m156�[0m, in �[35mjoin�[0m
    res = self._popen.wait(timeout)
  File �[35m"/buildbot/buildarea/3.x.ware-debian-x86.nondebug/build/Lib/multiprocessing/popen_fork.py"�[0m, line �[35m44�[0m, in �[35mwait�[0m
    return �[31mself.poll�[0m�[1;31m(os.WNOHANG if timeout == 0.0 else 0)�[0m
           �[31m~~~~~~~~~�[0m�[1;31m^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^�[0m
  File �[35m"/buildbot/buildarea/3.x.ware-debian-x86.nondebug/build/Lib/multiprocessing/popen_fork.py"�[0m, line �[35m28�[0m, in �[35mpoll�[0m
    pid, sts = �[31mos.waitpid�[0m�[1;31m(self.pid, flag)�[0m
               �[31m~~~~~~~~~~�[0m�[1;31m^^^^^^^^^^^^^^^^�[0m
  File �[35m"/buildbot/buildarea/3.x.ware-debian-x86.nondebug/build/Lib/test/_test_multiprocessing.py"�[0m, line �[35m574�[0m, in �[35mhandler�[0m
    raise RuntimeError('join took too long: %s' % p)
�[1;35mRuntimeError�[0m: �[35mjoin took too long: <Process name='Process-1' pid=12129 parent=12127 started daemon>�[0m


Traceback (most recent call last):
  File �[35m"/buildbot/buildarea/3.x.ware-debian-x86.nondebug/build/Lib/contextlib.py"�[0m, line �[35m85�[0m, in �[35minner�[0m
    return func(*args, **kwds)
  File �[35m"/buildbot/buildarea/3.x.ware-debian-x86.nondebug/build/Lib/test/_test_multiprocessing.py"�[0m, line �[35m597�[0m, in �[35mtest_interrupt�[0m
    exitcode = self._kill_process(multiprocessing.Process.interrupt)
  File �[35m"/buildbot/buildarea/3.x.ware-debian-x86.nondebug/build/Lib/contextlib.py"�[0m, line �[35m85�[0m, in �[35minner�[0m
    return func(*args, **kwds)
  File �[35m"/buildbot/buildarea/3.x.ware-debian-x86.nondebug/build/Lib/test/_test_multiprocessing.py"�[0m, line �[35m578�[0m, in �[35m_kill_process�[0m
    self.assertEqual(�[31mjoin�[0m�[1;31m()�[0m, None)
                     �[31m~~~~�[0m�[1;31m^^�[0m
  File �[35m"/buildbot/buildarea/3.x.ware-debian-x86.nondebug/build/Lib/test/_test_multiprocessing.py"�[0m, line �[35m251�[0m, in �[35m__call__�[0m
    return �[31mself.func�[0m�[1;31m(*args, **kwds)�[0m
           �[31m~~~~~~~~~�[0m�[1;31m^^^^^^^^^^^^^^^�[0m
  File �[35m"/buildbot/buildarea/3.x.ware-debian-x86.nondebug/build/Lib/multiprocessing/process.py"�[0m, line �[35m156�[0m, in �[35mjoin�[0m
    res = self._popen.wait(timeout)
  File �[35m"/buildbot/buildarea/3.x.ware-debian-x86.nondebug/build/Lib/multiprocessing/popen_fork.py"�[0m, line �[35m44�[0m, in �[35mwait�[0m
    return �[31mself.poll�[0m�[1;31m(os.WNOHANG if timeout == 0.0 else 0)�[0m
           �[31m~~~~~~~~~�[0m�[1;31m^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^�[0m
  File �[35m"/buildbot/buildarea/3.x.ware-debian-x86.nondebug/build/Lib/multiprocessing/popen_fork.py"�[0m, line �[35m28�[0m, in �[35mpoll�[0m
    pid, sts = �[31mos.waitpid�[0m�[1;31m(self.pid, flag)�[0m
               �[31m~~~~~~~~~~�[0m�[1;31m^^^^^^^^^^^^^^^^�[0m
  File �[35m"/buildbot/buildarea/3.x.ware-debian-x86.nondebug/build/Lib/test/_test_multiprocessing.py"�[0m, line �[35m574�[0m, in �[35mhandler�[0m
    raise RuntimeError('join took too long: %s' % p)
�[1;35mRuntimeError�[0m: �[35mjoin took too long: <Process name='Process-158' pid=21989 parent=19679 started daemon>�[0m

JelleZijlstra pushed a commit that referenced this pull request Mar 20, 2026
@miss-islington @mschoettle
[3.14] gh-145754: Update signature retrieval in unittest.mock to use …
7ba9580 
…forwardref annotation format (GH-145756) (#146191)

gh-145754: Update signature retrieval in unittest.mock to use forwardref annotation format (GH-145756)
(cherry picked from commit d357a7d)

Co-authored-by: Matthias Schoettle <git@mattsch.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjw296 cjw296 Awaiting requested review from cjw296 cjw296 is a code owner

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Autospeccing with unittest.mock is less robust with PEP 649

3 participants

@mschoettle @JelleZijlstra @bedevere-bot