Skip to content

Bump mypy to 1.19.1#145956

Merged
sobolevn merged 2 commits intopython:mainfrom
brianschubert:bump-mypy-1191
Mar 15, 2026
Merged

Bump mypy to 1.19.1#145956
sobolevn merged 2 commits intopython:mainfrom
brianschubert:bump-mypy-1191

Conversation

@brianschubert
Copy link
Contributor

@brianschubert brianschubert commented Mar 15, 2026

Closes #145950

New mypy errors:

Lib/test/libregrtest/utils.py:174: error: Incompatible types in assignment (expression has type "Callable[[_ExceptHookArgs], object]", variable has type "Callable[..., None] | None")  [assignment]
        orig_threading_excepthook = threading.excepthook
                                    ^~~~~~~~~~~~~~~~~~~~
Tools/clinic/libclinic/clanguage.py:67: error: Module has no attribute "cpp" [attr-defined]
            self.cpp = libclinic.cpp.Monitor(filename)
                       ^~~~~~~~~~~~~

First error is due to the return type of threading.excepthook changing from Any to object in a recent typeshed update.

The second error is due to the cpp submodule never being explicitly imported in clanguage's import graph, which can indeed lead to a runtime error:

>>> import libclinic.clanguage
>>> libclinic.clanguage.CLanguage("foo")
Traceback (most recent call last):
  File "<python-input-1>", line 1, in <module>
    libclinic.clanguage.CLanguage("foo")
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^
  File "/home/brian/Projects/open-contrib/cpython/Tools/clinic/libclinic/clanguage.py", line 67, in __init__
    self.cpp = libclinic.cpp.Monitor(filename)
               ^^^^^^^^^^^^^
AttributeError: module 'libclinic' has no attribute 'cpp'

It only works at the moment due to an implicit dependency on libclinic.cli being imported first, which imports libclinic.cpp.

@brianschubert brianschubert requested a review from sobolevn March 15, 2026 01:01
@sobolevn sobolevn merged commit e167e06 into python:main Mar 15, 2026
68 checks passed
@miss-islington-app
Copy link

miss-islington-app bot commented Mar 15, 2026

Thanks @brianschubert for the PR, and @sobolevn for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 15, 2026
@brianschubert @miss-islington
Bump mypy to 1.19.1 (pythonGH-145956)
8aeb2d6 
(cherry picked from commit e167e06)

Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 15, 2026
@brianschubert @miss-islington
Bump mypy to 1.19.1 (pythonGH-145956)
37c6c47 
(cherry picked from commit e167e06)

Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Mar 15, 2026

GH-145971 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Mar 15, 2026
@bedevere-app
Copy link

bedevere-app bot commented Mar 15, 2026

GH-145972 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Mar 15, 2026
sobolevn pushed a commit that referenced this pull request Mar 15, 2026
@miss-islington @brianschubert
[3.13] Bump mypy to 1.19.1 (GH-145956) (#145972)
c733046 
Bump mypy to 1.19.1 (GH-145956)
(cherry picked from commit e167e06)

Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
sobolevn pushed a commit that referenced this pull request Mar 15, 2026
@miss-islington @brianschubert
[3.14] Bump mypy to 1.19.1 (GH-145956) (#145971)
54fd676 
Bump mypy to 1.19.1 (GH-145956)
(cherry picked from commit e167e06)

Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevn sobolevn sobolevn approved these changes

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@brianschubert @sobolevn