Skip to content

gh-145990: sort --help-env sections by environment variable name#145997

Merged
gpshead merged 2 commits intopython:mainfrom
gpshead:sort-help-env
Mar 15, 2026
Merged

gh-145990: sort --help-env sections by environment variable name#145997
gpshead merged 2 commits intopython:mainfrom
gpshead:sort-help-env

Conversation

@gpshead
Copy link
Member

@gpshead gpshead commented Mar 15, 2026 •
edited by bedevere-app bot
Loading

@gpshead gpshead self-assigned this Mar 15, 2026
@bedevere-app bedevere-app bot mentioned this pull request Mar 15, 2026
Closed
@gpshead gpshead marked this pull request as ready for review March 15, 2026 21:56
@gpshead gpshead requested a review from StanFromIreland March 15, 2026 21:56
@gpshead gpshead added the docs Documentation in the Doc dir label Mar 15, 2026
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Mar 15, 2026
@picnixz picnixz changed the title gh-145990: sort --help-env sections by name` gh-145990: sort --help-env sections by name Mar 15, 2026
@picnixz picnixz changed the title gh-145990: sort --help-env sections by name gh-145990: sort --help-env sections by environment variable name Mar 15, 2026
gpshead added a commit to gpshead/cpython that referenced this pull request Mar 15, 2026
@gpshead
pythongh-145990: sort --help-env sections by environment name
80297ba 
manual backport of pythonGH-145997
This was referenced Mar 15, 2026
Merged
Merged
@gpshead gpshead added the tests Tests in the Lib/test dir label Mar 15, 2026
@gpshead gpshead merged commit 83edae3 into python:main Mar 15, 2026
56 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Mar 15, 2026
@StanFromIreland
Copy link
Member

StanFromIreland commented Mar 15, 2026

Slightly too late 😆, but LGTM!

gpshead added a commit that referenced this pull request Mar 15, 2026
@gpshead
[3.13] gh-145990: sort --help-env first section by name (others and x…
102cd61 
…options already sorted) (GH-146003)

* sort `--help-env` sections by environment variable name
  Only needed in the first section, in 3.13 the second section was already sorted.
* regression test for --help-env & --help-xoptions sort order

Manual backport of GH-145997
gpshead added a commit that referenced this pull request Mar 15, 2026
@gpshead
[3.14] gh-145990: sort --help-env sections by environment variable …
b8cb837 
…name (GH-146001)

* sort --help-env alphabetically by name.
* add a sorting regression test in test_help_env.

manual backport of GH-145997
@bedevere-bot
Copy link

bedevere-bot commented Mar 15, 2026

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.x (tier-1) has failed when building commit 83edae3.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/345/builds/13667) and take a look at the build logs.
  4. Check if the failure is related to this commit (83edae3) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/345/builds/13667

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 947, in gc_collect
    gc.collect()
    ~~~~~~~~~~^^
ResourceWarning: unclosed file <_io.FileIO name=11 mode='wb' closefd=True>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

@StanFromIreland StanFromIreland Awaiting requested review from StanFromIreland

Assignees

@gpshead gpshead

Labels

docs Documentation in the Doc dir tests Tests in the Lib/test dir

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gpshead @StanFromIreland @bedevere-bot