gh-140795: Put the thread state in PyCriticalSection structs#146066
Closed
encukou wants to merge 1 commit intopython:mainfrom
Closed
gh-140795: Put the thread state in PyCriticalSection structs#146066encukou wants to merge 1 commit intopython:mainfrom
encukou wants to merge 1 commit intopython:mainfrom
Conversation
pythonGH-141406 improved performance by only fetching thread state once and storing it in a variable on the stack. This instead puts the thread state in the PyCriticalState struct (also a temp variable on the stack), bringing the public and private implementations closer together.
Contributor
|
I used Claude to benchmark the PR on Linux in a few cases (main executable, https://github.com/colesbury/gh-140795-benchmarks/blob/main/results.txt |
Contributor
The important part that this PR misses is that in my PR the thread state is passed in a register whereas here it will need to be loaded from stack, I don't see value in doing this unless the performance is atleast equal. |
Member
Author
|
I see. In my (much more limited) testing this looked better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GH-141406 improved performance by only fetching thread state once and storing it in a variable on the stack.
This instead puts the thread state in the PyCriticalState struct (also a temp variable on the stack), bringing the public and private implementations closer together.