gh-146093: Fix csv _set_str(): check if PyUnicode_DecodeASCII() failed#146113
Merged
vstinner merged 1 commit intopython:mainfrom Mar 18, 2026
Merged
gh-146093: Fix csv _set_str(): check if PyUnicode_DecodeASCII() failed#146113vstinner merged 1 commit intopython:mainfrom
vstinner merged 1 commit intopython:mainfrom
Conversation
… failed The function can fail on a memory allocation failure. Bug reported by devdanzin.
Member
Author
|
Writing a test requires using |
Member
|
It can also fail for non-ASCII data, isn't? |
serhiy-storchaka
approved these changes
Mar 18, 2026
Member
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Ah, the default is hardcoded ASCII string. LGTM. 👍
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 18, 2026
… failed (pythonGH-146113) The function can fail on a memory allocation failure. Bug reported by devdanzin. (cherry picked from commit 724c7c8) Co-authored-by: Victor Stinner <vstinner@python.org>
|
GH-146130 is a backport of this pull request to the 3.14 branch. |
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 18, 2026
… failed (pythonGH-146113) The function can fail on a memory allocation failure. Bug reported by devdanzin. (cherry picked from commit 724c7c8) Co-authored-by: Victor Stinner <vstinner@python.org>
|
GH-146131 is a backport of this pull request to the 3.13 branch. |
Member
Author
|
Merged. Thanks for your review @serhiy-storchaka. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function can fail on a memory allocation failure.
Bug reported by devdanzin.
_set_strmissingNULLcheck afterPyUnicode_DecodeASCIIin_csv.c#146093