Skip to content

gh-146092: Handle _PyFrame_GetFrameObject() failures properly#146124

Merged
vstinner merged 1 commit intopython:mainfrom
vstinner:frame_getlocals
Mar 18, 2026
Merged

gh-146092: Handle _PyFrame_GetFrameObject() failures properly#146124
vstinner merged 1 commit intopython:mainfrom
vstinner:frame_getlocals

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Mar 18, 2026

  • Fix _PyFrame_GetLocals() and _PyFrame_GetLocals() error handling.
  • _PyEval_ExceptionGroupMatch() now fails on _PyFrame_GetLocals() error.

* Fix _PyFrame_GetLocals() and _PyFrame_GetLocals() error handling.
* _PyEval_ExceptionGroupMatch() now fails on _PyFrame_GetLocals()
  error.
@vstinner vstinner merged commit e1e4852 into python:main Mar 18, 2026
67 checks passed
@vstinner vstinner deleted the frame_getlocals branch March 18, 2026 17:27
@miss-islington-app
Copy link

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @vstinner, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker e1e4852133ea548479bc9b975420a32331df7cee 3.14

@vstinner
Copy link
Member Author

PR merged. Thanks for your review @kumaraditya303.

@miss-islington-app
Copy link

Sorry, @vstinner, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker e1e4852133ea548479bc9b975420a32331df7cee 3.13

vstinner added a commit to vstinner/cpython that referenced this pull request Mar 18, 2026
…ython#146124)

* Fix _PyFrame_GetLocals() and _PyFrame_GetLocals() error handling.
* _PyEval_ExceptionGroupMatch() now fails on _PyFrame_GetLocals()
  error.

(cherry picked from commit e1e4852)
@bedevere-app
Copy link

bedevere-app bot commented Mar 18, 2026

GH-146132 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Mar 18, 2026
@vstinner vstinner removed the needs backport to 3.13 bugs and security fixes label Mar 18, 2026
vstinner added a commit that referenced this pull request Mar 18, 2026
…146124) (#146132)

gh-146092: Handle _PyFrame_GetFrameObject() failures properly (#146124)

* Fix _PyFrame_GetLocals() and _PyFrame_GetLocals() error handling.
* _PyEval_ExceptionGroupMatch() now fails on _PyFrame_GetLocals()
  error.

(cherry picked from commit e1e4852)
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 18, 2026
…perly (pythonGH-146124) (pythonGH-146132)

pythongh-146092: Handle _PyFrame_GetFrameObject() failures properly (pythonGH-146124)

* Fix _PyFrame_GetLocals() and _PyFrame_GetLocals() error handling.
* _PyEval_ExceptionGroupMatch() now fails on _PyFrame_GetLocals()
  error.
(cherry picked from commit 8eeb800)

Co-authored-by: Victor Stinner <vstinner@python.org>
(cherry picked from commit e1e4852)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants