gh-145410: Fix sysconfig.get_platform() for truncated sys.version on Windows#146146
Closed
Jah-yee wants to merge 1 commit intopython:mainfrom
Closed
gh-145410: Fix sysconfig.get_platform() for truncated sys.version on Windows#146146Jah-yee wants to merge 1 commit intopython:mainfrom
Jah-yee wants to merge 1 commit intopython:mainfrom
Conversation
On Windows, sysconfig.get_platform() checks for 'amd64' in sys.version to detect 64-bit builds. However, sys.version can be truncated (e.g., ~100 chars on clang builds), causing 'amd64' to be missing and returning 'win32' incorrectly. This fix adds sys.maxsize > 2**32 as a fallback check, which is reliable even when sys.version is truncated. Also reorders arm64 check before arm32 for proper precedence. Fixes: python#145410
|
The following commit authors need to sign the Contributor License Agreement: |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Member
|
This was resolved by b9d4318. Also I see this was "Submitted by automated agent." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fix
On Windows,
sysconfig.get_platform()checks for the string'amd64'insys.versionto detect 64-bit builds. However,sys.versioncan be truncated (e.g., ~100 characters on clang builds), causing'amd64'to be missing and returning'win32'incorrectly.This causes problems when installing native packages via pip because
cp314-cp314-amd64is not in the list of supported tags.The Fix
This PR adds
sys.maxsize > 2**32as a fallback check, which is reliable even whensys.versionis truncated. It also reorders the arm64 check before arm32 for proper precedence.Before:
After:
Fixes: #145410
Submitted by automated agent