Skip to content

gh-146153: Use frozendict in pure python fallback for curses.has_key #146154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jonathandung wants to merge 11 commits into
base: main
Choose a base branch
from
+4 −3
Open

gh-146153: Use frozendict in pure python fallback for curses.has_key #146154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
540afcd
Use frozenmap in curses/has_key.py
jonathandung Mar 19, 2026
c51e72c
Remove whitespace surrounding parentheses
jonathandung Mar 19, 2026
8518484
Merge branch 'python:main' into patch-1
jonathandung Mar 19, 2026
805dcb2
📜🤖 Added by blurb_it.
blurb-it[bot] Mar 19, 2026
6f25f93
Edit news
jonathandung Mar 19, 2026
4891f62
Update 2026-03-19-08-48-21.gh-issue-146153.UTK9Mb.rst
jonathandung Mar 19, 2026
256374f
Fix linter error
jonathandung Mar 19, 2026
c34da91
It's called frozendict
jonathandung Mar 19, 2026
c2aebbb
Update 2026-03-19-08-48-21.gh-issue-146153.UTK9Mb.rst
jonathandung Mar 19, 2026
16d4d2c
Merge branch 'main' into patch-1
jonathandung Mar 19, 2026
f4fec4c
Merge branch 'main' into patch-1
jonathandung Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Lib/curses/has_key.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

# Table mapping curses keys to the terminfo capability name

_capability_names = {
_capability_names = frozendict({
_curses.KEY_A1: 'ka1',
_curses.KEY_A3: 'ka3',
_curses.KEY_B2: 'kb2',
Expand Down Expand Up @@ -157,7 +157,7 @@
_curses.KEY_SUSPEND: 'kspd',
_curses.KEY_UNDO: 'kund',
_curses.KEY_UP: 'kcuu1'
}
})

def has_key(ch):
if isinstance(ch, str):
Expand All @@ -170,7 +170,7 @@ def has_key(ch):

#Check the current terminal description for that capability;
#if present, return true, else return false.
if _curses.tigetstr( capability_name ):
if _curses.tigetstr(capability_name):
return True
else:
return False
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2026-03-19-08-48-21.gh-issue-146153.UTK9Mb.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Changed the ``_capability_names`` dictionary in :mod:`curses.has_key` to a :class:`frozendict`, since it is private and requires no modifications. Contributed by Jonathan Dung.
Loading