gh-145865: Fix CoverageResults.__init__ to copy the counts dict#146176
Closed
kimimgo wants to merge 2 commits intopython:mainfrom
Closed
gh-145865: Fix CoverageResults.__init__ to copy the counts dict#146176kimimgo wants to merge 2 commits intopython:mainfrom
kimimgo wants to merge 2 commits intopython:mainfrom
Conversation
…on#146044) The unix-word-rubout command (ctrl-w) was using syntax_table-based word boundaries (bow()), which treats punctuation as word separators. This differs from bash/readline's unix-word-rubout which uses only whitespace as word boundaries. Add bow_whitespace() method that uses whitespace-only boundaries, and use it in unix_word_rubout instead of bow(). The existing bow() method (used by backward-kill-word/M-Backspace) is unchanged. Example: with 'foo.bar baz' and cursor at end: - Before (bow): ctrl-w deletes 'baz', then 'bar', then 'foo' - After (bow_whitespace): ctrl-w deletes 'baz', then 'foo.bar'
Fix typo where self.counter was assigned instead of self.counts, causing the counts dict to not be copied. This made CoverageResults.update() mutate the caller's original dict. The fix changes self.counter = self.counts.copy() to self.counts = self.counts.copy(), matching the pattern used for calledfuncs and callers on the following lines. Also removes the dead self.counter attribute which was never read anywhere in the codebase.
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
All commit authors signed the Contributor License Agreement. |
Member
|
You have unrelated changes mixed in, can you please split them? |
Author
|
Closing to resubmit with clean branch — the original PR had unrelated pyrepl changes mixed in. See new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #145865
Summary
CoverageResults.__init__had a typo on line 158:should be:
This caused
self.countsto be an alias to the caller's dict, soupdate()would mutate the original dict. The deadself.counterattribute was never read anywhere.
Tests
Added
TestCoverageResultsInitwith 3 tests verifying thatcounts,calledfuncs, andcallersdicts are all properly copied and notmutated by
update().trace.CoverageResults.__init__does not copy the counts dict #145865