Skip to content

gh-145865: Fix CoverageResults.__init__ to copy the counts dict #146183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kimimgo wants to merge 2 commits into
base: main
Choose a base branch
from
+31 −1
Open

gh-145865: Fix CoverageResults.__init__ to copy the counts dict #146183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78a81d8
gh-145865: Fix CoverageResults.__init__ to copy the counts dict
kimimgo Mar 19, 2026
d658d7a
Add NEWS entry for gh-145865
kimimgo Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions Lib/test/test_trace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,5 +590,32 @@ def test_no_source_file(self):
self.assertIn(f"{filename}({firstlineno + 4})", out[4])


class TestCoverageResultsInit(unittest.TestCase):
def test_counts_dict_is_copied(self):
# gh-145865: CoverageResults.__init__ should copy the counts dict
from trace import CoverageResults

counts = {}
cr = CoverageResults(counts=counts)
cr.update(CoverageResults(counts={("file.py", 1): 5}))
self.assertEqual(counts, {})

def test_calledfuncs_dict_is_copied(self):
from trace import CoverageResults

calledfuncs = {}
cr = CoverageResults(calledfuncs=calledfuncs)
cr.update(CoverageResults(calledfuncs={("file.py", "mod", "func"): 1}))
self.assertEqual(calledfuncs, {})

def test_callers_dict_is_copied(self):
from trace import CoverageResults

callers = {}
cr = CoverageResults(callers=callers)
cr.update(CoverageResults(callers={(("a.py", "m", "f"), ("b.py", "m", "g")): 1}))
self.assertEqual(callers, {})


if __name__ == '__main__':
unittest.main()
2 changes: 1 addition & 1 deletion Lib/trace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ def __init__(self, counts=None, calledfuncs=None, infile=None,
self.counts = counts
if self.counts is None:
self.counts = {}
self.counter = self.counts.copy() # map (filename, lineno) to count
self.counts = self.counts.copy() # map (filename, lineno) to count
self.calledfuncs = calledfuncs
if self.calledfuncs is None:
self.calledfuncs = {}
Expand Down
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Library/2026-03-20-00-00-00.gh-issue-145865.TrCpCo.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Fix typo in :class:`trace.CoverageResults` where ``self.counter`` was
assigned instead of ``self.counts``, causing the ``counts`` dict to not
be copied and ``update()`` to mutate the caller's original dict.
Loading