gh-145866: Implement POP_ITER as macro op using POP_TOP#146185
Open
bkap123 wants to merge 4 commits intopython:mainfrom
Open
gh-145866: Implement POP_ITER as macro op using POP_TOP#146185bkap123 wants to merge 4 commits intopython:mainfrom
POP_ITER as macro op using POP_TOP#146185bkap123 wants to merge 4 commits intopython:mainfrom
Conversation
As the JIT can optimize `_POP_TOP` uops, I implemented `POP_TOP` for the `POP_ITER` instruction. I am fairly confident that this is the right solution but I am new to the JIT and would welcome any feedback.
|
|
||
| def test_pop_iter(self): | ||
| def testfunc(n): | ||
| for _ in range(n): |
Member
There was a problem hiding this comment.
This test seems wrong. It's not testing for POP_ITER, or at least it's not in the trace
Contributor
Author
There was a problem hiding this comment.
What do you think I should change? When I wrote the test, I just wanted to make sure that a POP_ITER instruction would be converted into only one _POP_TOP uop as that was the goal of the original issue. Maybe it might be helpful to rename the test to something like test_pop_iter_uop_expansion?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the JIT can optimize
_POP_TOPuops, I implementedPOP_TOPfor thePOP_ITERinstruction. I am fairly confident that this is the right solution but I am new to the JIT and would welcome any feedback._POP_TOP#145866