gh-146219: Document reusing a thread state across repeated foreign-thread calls#146221
Open
gpshead wants to merge 1 commit intopython:mainfrom
Open
gh-146219: Document reusing a thread state across repeated foreign-thread calls#146221gpshead wants to merge 1 commit intopython:mainfrom
gpshead wants to merge 1 commit intopython:mainfrom
Conversation
Add a subsection under "Non-Python created threads" explaining the performance cost of creating/destroying a PyThreadState on every Ensure/Release cycle and showing how to keep one alive for the thread's lifetime instead.
Member
|
|
||
| /* Thread startup: create and pin the state. */ | ||
| PyGILState_STATE outer = PyGILState_Ensure(); | ||
| PyThreadState *saved = PyEval_SaveThread(); |
Member
There was a problem hiding this comment.
Hm, what's the point of detaching the thread state again? PyGILState_Ensure is able to handle nested calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a subsection under "Non-Python created threads" explaining the performance cost of creating/destroying a PyThreadState on every Ensure/Release cycle and showing how to keep one alive for the thread's lifetime instead.
(read them & see the issue for more details)
📚 Documentation preview 📚: https://cpython-previews--146221.org.readthedocs.build/