Skip to content

[3.13] gh-129849: Add tests for Py_tp_bases (GH-143208) #146226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumaraditya303 merged 1 commit into from
Mar 21, 2026
+58 −0
Merged

[3.13] gh-129849: Add tests for Py_tp_bases (GH-143208) #146226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions Lib/test/test_capi/test_misc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1152,6 +1152,18 @@ def genf(): yield
gen = genf()
self.assertEqual(_testcapi.gen_get_code(gen), gen.gi_code)

def test_tp_bases_slot(self):
cls = _testcapi.HeapCTypeWithBasesSlot
self.assertEqual(cls.__bases__, (int,))
self.assertEqual(cls.__base__, int)

def test_tp_bases_slot_none(self):
self.assertRaisesRegex(
SystemError,
"Py_tp_bases is not a tuple",
_testcapi.create_heapctype_with_none_bases_slot
)


@requires_limited_api
class TestHeapTypeRelative(unittest.TestCase):
Expand Down
46 changes: 46 additions & 0 deletions Modules/_testcapi/heaptype.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,6 +410,26 @@ pyobject_getitemdata(PyObject *self, PyObject *o)
}


static PyType_Slot HeapCTypeWithBasesSlotNone_slots[] = {
{Py_tp_bases, NULL}, /* filled out with Py_None in runtime */
{0, 0},
};

static PyType_Spec HeapCTypeWithBasesSlotNone_spec = {
.name = "_testcapi.HeapCTypeWithBasesSlotNone",
.basicsize = sizeof(PyObject),
.flags = Py_TPFLAGS_DEFAULT,
.slots = HeapCTypeWithBasesSlotNone_slots
};

static PyObject *
create_heapctype_with_none_bases_slot(PyObject *self, PyObject *Py_UNUSED(ignored))
{
HeapCTypeWithBasesSlotNone_slots[0].pfunc = Py_None;
return PyType_FromSpec(&HeapCTypeWithBasesSlotNone_spec);
}


static PyMethodDef TestMethods[] = {
{"pytype_fromspec_meta", pytype_fromspec_meta, METH_O},
{"test_type_from_ephemeral_spec", test_type_from_ephemeral_spec, METH_NOARGS},
Expand All @@ -423,6 +443,8 @@ static PyMethodDef TestMethods[] = {
{"make_immutable_type_with_base", make_immutable_type_with_base, METH_O},
{"make_type_with_base", make_type_with_base, METH_O},
{"pyobject_getitemdata", pyobject_getitemdata, METH_O},
{"create_heapctype_with_none_bases_slot",
create_heapctype_with_none_bases_slot, METH_NOARGS},
{NULL},
};

Expand Down Expand Up @@ -751,6 +773,18 @@ static PyType_Spec HeapCTypeMetaclassNullNew_spec = {
.slots = empty_type_slots
};

static PyType_Slot HeapCTypeWithBasesSlot_slots[] = {
{Py_tp_bases, NULL}, /* filled out in module init function */
{0, 0},
};

static PyType_Spec HeapCTypeWithBasesSlot_spec = {
.name = "_testcapi.HeapCTypeWithBasesSlot",
.basicsize = sizeof(PyLongObject),
.flags = Py_TPFLAGS_DEFAULT | Py_TPFLAGS_BASETYPE,
.slots = HeapCTypeWithBasesSlot_slots
};


typedef struct {
PyObject_HEAD
Expand Down Expand Up @@ -1201,6 +1235,18 @@ _PyTestCapi_Init_Heaptype(PyObject *m) {
&PyType_Type, m, &HeapCTypeMetaclassNullNew_spec, (PyObject *) &PyType_Type);
ADD("HeapCTypeMetaclassNullNew", HeapCTypeMetaclassNullNew);

PyObject *bases = PyTuple_Pack(1, &PyLong_Type);
if (bases == NULL) {
return -1;
}
HeapCTypeWithBasesSlot_slots[0].pfunc = bases;
PyObject *HeapCTypeWithBasesSlot = PyType_FromSpec(&HeapCTypeWithBasesSlot_spec);
Py_DECREF(bases);
if (HeapCTypeWithBasesSlot == NULL) {
return -1;
}
ADD("HeapCTypeWithBasesSlot", HeapCTypeWithBasesSlot);

PyObject *HeapCCollection = PyType_FromMetaclass(
NULL, m, &HeapCCollection_spec, NULL);
if (HeapCCollection == NULL) {
Expand Down
Loading