Skip to content

[3.12] gh-143930: Reject leading dashes in webbrowser URLs#146360

Merged
ambv merged 2 commits intopython:3.12from
Pinky-Chaudhary:backport-82a24a4-3.12
Mar 24, 2026
Merged

[3.12] gh-143930: Reject leading dashes in webbrowser URLs#146360
ambv merged 2 commits intopython:3.12from
Pinky-Chaudhary:backport-82a24a4-3.12

Conversation

@Pinky-Chaudhary
Copy link

@Pinky-Chaudhary Pinky-Chaudhary commented Mar 24, 2026 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Mar 24, 2026
Open
@Pinky-Chaudhary Pinky-Chaudhary changed the title gh-143930: Reject leading dashes in webbrowser URLs [3.12] gh-143930: Reject leading dashes in webbrowser URLs Mar 24, 2026
ambv
ambv requested changes Mar 24, 2026
View reviewed changes
Copy link
Contributor

@ambv ambv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The backport needs to be equivalent to what was landed in 3.13 - 3.15. Don't make any other changes.

@bedevere-app
Copy link

bedevere-app bot commented Mar 24, 2026

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@python-cla-bot
Copy link

python-cla-bot bot commented Mar 24, 2026 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@Pinky-Chaudhary
Copy link
Author

Pinky-Chaudhary commented Mar 24, 2026

I have made the requested changes; please review again

@bedevere-app
Copy link

bedevere-app bot commented Mar 24, 2026

Thanks for making the requested changes!

@ambv: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from ambv March 24, 2026 18:33
@ambv ambv merged commit cbba611 into python:3.12 Mar 24, 2026
29 of 32 checks passed
@ambv
Copy link
Contributor

ambv commented Mar 24, 2026

Thanks, @Pinky-Chaudhary!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambv ambv ambv approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Pinky-Chaudhary @ambv @sethmlarson