gh-146388: Add null check for sym_new(ctx) in make_bottom#146389
Draft
A0su wants to merge 2 commits intopython:mainfrom
Draft
gh-146388: Add null check for sym_new(ctx) in make_bottom#146389A0su wants to merge 2 commits intopython:mainfrom
sym_new(ctx) in make_bottom#146389A0su wants to merge 2 commits intopython:mainfrom
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
optimizer_symbols.c: make_bottom NULL deref when arena full
sym_new(ctx)at line 1535 can return NULL when the type arena is full. Result immediately dereferenced without check. Every othersym_newcall site checks for NULL.This is a sub-issue of #146102 with gist details
optimizer_symbols.c:make_bottomNULL deref when arena full #146388