[3.14] GH-136895: Update JIT builds to use LLVM 21 (GH-140329)#146420
Open
mcepl wants to merge 3 commits intopython:3.14from
Open
[3.14] GH-136895: Update JIT builds to use LLVM 21 (GH-140329)#146420mcepl wants to merge 3 commits intopython:3.14from
mcepl wants to merge 3 commits intopython:3.14from
Conversation
- Enable x86_64 trampoline support on all x86_64 platforms, not just macOS. While currently only macOS emits X86_64_RELOC_BRANCH relocations, this ensures the trampoline infrastructure is ready if future LLVM changes produce out-of-range calls on other x86_64 platforms. - Add error handling to extract_tarball() in get_external.py so that corrupted or incomplete downloads produce a clear error message instead of an opaque traceback. - Replace hardcoded LLVM version check in get_externals.bat with a prefix-based 'llvm-' match using findstr, so future LLVM version bumps only require changing the version string in one place.
Bump the JIT toolchain from LLVM 20 to LLVM 21 (21.1.8). Updated across CI workflows, build scripts, documentation, and the externals tag.
b6c50f4 to
539f0f1
Compare
Member
|
I don't think we can do this. Changing a build dependency in a patch release of 3.14 is very strange and usually not allowed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of GH-140329 to 3.14, with the addition of:
Enable x86_64 trampoline support on all x86_64 platforms, not just
macOS. While currently only macOS emits X86_64_RELOC_BRANCH
relocations, this ensures the trampoline infrastructure is ready if
future LLVM changes produce out-of-range calls on other x86_64
platforms.
Add error handling to extract_tarball() in get_external.py so that
corrupted or incomplete downloads produce a clear error message
instead of an opaque traceback.
Replace hardcoded LLVM version check in get_externals.bat with
a prefix-based 'llvm-' match using findstr, so future LLVM version
bumps only require changing the version string in one place.
Also, bump the JIT toolchain from LLVM 20 to LLVM 21 (21.1.8). Updated across
CI workflows, build scripts, documentation, and the externals tag.