Skip to content

[3.13] gh-146059: Call fast_save_leave() in pickle save_frozenset() (GH-146173)#146474

Merged
vstinner merged 2 commits intopython:3.13from
miss-islington:backport-5c0dcb3-3.13
Mar 27, 2026
Merged

[3.13] gh-146059: Call fast_save_leave() in pickle save_frozenset() (GH-146173)#146474
vstinner merged 2 commits intopython:3.13from
miss-islington:backport-5c0dcb3-3.13

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Mar 26, 2026 •
edited by bedevere-app bot
Loading

Add more pickle tests: test also nested structures.
(cherry picked from commit 5c0dcb3)

Co-authored-by: Victor Stinner vstinner@python.org

@vstinner @miss-islington
pythongh-146059: Call fast_save_leave() in pickle save_frozenset() (p…
16abed6 
…ythonGH-146173)

Add more pickle tests: test also nested structures.
(cherry picked from commit 5c0dcb3)

Co-authored-by: Victor Stinner <vstinner@python.org>
This was referenced Mar 26, 2026
Closed
Merged
@vstinner vstinner enabled auto-merge (squash) March 26, 2026 16:36
@vstinner
Copy link
Member

vstinner commented Mar 27, 2026

Oh, test_deep_nested_struct_set() fails on WASI because it uses too much stack memory:

test_deep_nested_struct_set (test.test_pickle.DumpPickle_CLoadPickle.test_deep_nested_struct_set) ... Error: failed to run main module `python.wasm`

Caused by:
    0: failed to invoke command default
    1: error while executing at wasm backtrace:
           0: python.wasm!_PyEval_EvalFrameDefault
           1: 0x29f42d - python.wasm!_PyEval_Vector
           2: 0xcfe79 - python.wasm!_PyFunction_Vectorcall
           3: 0x352dd8 - python.wasm!sys_audit_tstate
           4: 0x35323f - python.wasm!PySys_Audit
           5: 0x26efdb - python.wasm!builtin_id
           6: 0x27bfe5 - python.wasm!_PyEval_EvalFrameDefault
...

I skipped the test on WASI.

@vstinner vstinner mentioned this pull request Mar 27, 2026
Merged
@vstinner vstinner merged commit de1644c into python:3.13 Mar 27, 2026
40 checks passed
@miss-islington miss-islington deleted the backport-5c0dcb3-3.13 branch March 27, 2026 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@miss-islington @vstinner