Skip to content

gh-146090: fix memory management of internal sqlite3 callback contexts#146569

Merged
picnixz merged 3 commits intopython:mainfrom
picnixz:fix/sqlite/refcounting-api-146090
Mar 29, 2026
Merged

gh-146090: fix memory management of internal sqlite3 callback contexts#146569
picnixz merged 3 commits intopython:mainfrom
picnixz:fix/sqlite/refcounting-api-146090

Conversation

@picnixz
Copy link
Copy Markdown
Member

@picnixz picnixz commented Mar 28, 2026 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Mar 28, 2026
Closed
@picnixz picnixz added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Mar 28, 2026
@picnixz picnixz linked an issue Mar 28, 2026 that may be closed by this pull request
Assertion failure in free_callback_context via create_collation and missing PyErr_NoMemory in create_callback_context #146090
Closed
@picnixz picnixz added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Mar 28, 2026
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Mar 28, 2026

🤖 New build scheduled with the buildbot fleet by @picnixz for commit 926804b 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F146569%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Mar 28, 2026
@picnixz picnixz changed the title gh-146090: fix memory management of SQLite3 callback contexts gh-146090: fix memory management of internal sqlite3 callback contexts Mar 29, 2026
@picnixz picnixz merged commit aa66807 into python:main Mar 29, 2026
66 checks passed
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app bot commented Mar 29, 2026

Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@picnixz picnixz deleted the fix/sqlite/refcounting-api-146090 branch March 29, 2026 12:21
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 29, 2026
@picnixz @miss-islington
pythongh-146090: fix memory management of internal sqlite3 callback…
a0192ad 
… contexts (pythonGH-146569)

(cherry picked from commit aa66807)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Mar 29, 2026

GH-146595 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Mar 29, 2026
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 29, 2026
@picnixz @miss-islington
pythongh-146090: fix memory management of internal sqlite3 callback…
1b5bd8e 
… contexts (pythonGH-146569)

(cherry picked from commit aa66807)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Mar 29, 2026

GH-146596 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Mar 29, 2026
picnixz added a commit that referenced this pull request Mar 29, 2026
@miss-islington @picnixz
[3.13] gh-146090: fix memory management of internal sqlite3 callbac…
6fdf084 
…k contexts (GH-146569) (#146596)

gh-146090: fix memory management of internal `sqlite3` callback contexts (GH-146569)
(cherry picked from commit aa66807)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz added a commit that referenced this pull request Mar 29, 2026
@miss-islington @picnixz
[3.14] gh-146090: fix memory management of internal sqlite3 callbac…
1458ea0 
…k contexts (GH-146569) (#146595)

gh-146090: fix memory management of internal `sqlite3` callback contexts (GH-146569)
(cherry picked from commit aa66807)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Assertion failure in free_callback_context via create_collation and missing PyErr_NoMemory in create_callback_context

2 participants

@picnixz @bedevere-bot