gh-147960: Avoid memory leak in _tuple_shared() on allocation failure#147961
Merged
vstinner merged 3 commits intopython:mainfrom Apr 1, 2026
Merged
gh-147960: Avoid memory leak in _tuple_shared() on allocation failure#147961vstinner merged 3 commits intopython:mainfrom
vstinner merged 3 commits intopython:mainfrom
Conversation
eendebakpt
approved these changes
Apr 1, 2026
Contributor
eendebakpt
left a comment
There was a problem hiding this comment.
We do not always add a news entry for leaks in the failure paths, but the fix seems good.
This reverts commit a05f591.
Member
|
Merged, thanks for the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a memory leak in _tuple_shared() when allocating the items array fails.
If PyMem_Calloc() for shared->items fails, the previously allocated
sharedstructure was not freed before returning, resulting in a leak.Add the missing PyMem_RawFree(shared) on the error path.
Signed-off-by: Yongtao Huang yongtaoh2022@gmail.com