Skip to content

gh-148286: Fail on new UB in CI#148168

Merged
StanFromIreland merged 11 commits intopython:mainfrom
StanFromIreland:san-ubsan
Apr 9, 2026
Merged

gh-148286: Fail on new UB in CI#148168
StanFromIreland merged 11 commits intopython:mainfrom
StanFromIreland:san-ubsan

Conversation

@StanFromIreland
Copy link
Copy Markdown
Member

@StanFromIreland StanFromIreland commented Apr 6, 2026 •
edited
Loading

Trying to debug a bit, it should be detecting #148166 (and also screaming about it), but it isn't. Mirroring what we do for the TSan job.

Just chucked everything in suppressions for now, they should be reviewed as it may have actual bugs.

@StanFromIreland StanFromIreland changed the title Fail on new UB Fail on new UB in CI Apr 6, 2026
@StanFromIreland
Copy link
Copy Markdown
Member Author

StanFromIreland commented Apr 6, 2026

I've never been so happy to see the CI fail :-)

[3](https://github.com/python/cpython/actions/runs/24037637122/job/70101135069?pr=148168#step:11:144)
==> /home/runner/work/cpython/cpython/san_log.26255 <==
Modules/binascii.c:1243:42: runtime error: left shift of 129 by 24 places cannot be represented in type 'int'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior Modules/binascii.c:1243:42

@thesamesam
Copy link
Copy Markdown
Contributor

thesamesam commented Apr 6, 2026

We got there in the end: #111758 (comment) :)

I'd assumed that #135578 or #136820 included that but I didn't check.

thesamesam
thesamesam reviewed Apr 6, 2026
View reviewed changes
thesamesam
thesamesam reviewed Apr 6, 2026
View reviewed changes
@StanFromIreland StanFromIreland marked this pull request as ready for review April 6, 2026 16:16
@StanFromIreland StanFromIreland marked this pull request as draft April 6, 2026 16:19
@StanFromIreland StanFromIreland marked this pull request as ready for review April 6, 2026 17:19
@encukou
Copy link
Copy Markdown
Member

encukou commented Apr 9, 2026

LGTM, thank you!
Consider opening an issue, which we could use to track the fixes too.

@StanFromIreland StanFromIreland changed the title Fail on new UB in CI gh-148286: Fail on new UB in CI Apr 9, 2026
@StanFromIreland
Copy link
Copy Markdown
Member Author

StanFromIreland commented Apr 9, 2026

Created #148286.

@StanFromIreland StanFromIreland requested a review from encukou April 9, 2026 08:47
@StanFromIreland StanFromIreland merged commit ade914b into python:main Apr 9, 2026
48 checks passed
@StanFromIreland StanFromIreland deleted the san-ubsan branch April 9, 2026 09:30
@StanFromIreland
Copy link
Copy Markdown
Member Author

StanFromIreland commented Apr 9, 2026

Thanks for the reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

@encukou encukou Awaiting requested review from encukou

1 more reviewer

@thesamesam thesamesam thesamesam left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StanFromIreland @thesamesam @encukou