gh-148208: Fix recursion depth leak in PyObject_Print#148209
Merged
gpshead merged 2 commits intopython:mainfrom Apr 12, 2026
Merged
gh-148208: Fix recursion depth leak in PyObject_Print#148209gpshead merged 2 commits intopython:mainfrom
PyObject_Print#148209gpshead merged 2 commits intopython:mainfrom
Conversation
Member
ZeroIntensity
left a comment
There was a problem hiding this comment.
Do you think you could come up with a simple test case to stress this?
Contributor
Author
|
Sorry, I'm not quite sure how to create tests for capi |
Member
|
Is |
Contributor
Author
|
Oh, that's true. Is it still necessary for me to add this? |
gpshead
approved these changes
Apr 12, 2026
Member
gpshead
left a comment
There was a problem hiding this comment.
while having a test would be neat, I don't think we need one for this. it's a pretty clear oversight in the code and not likely to regress.
|
Thanks @Wulian233 for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 12, 2026
…GH-148209) (cherry picked from commit e2fa10e04d3fed4c248881d69411fc208d05ad6b) Co-authored-by: Wulian233 <1055917385@qq.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 12, 2026
…GH-148209) (cherry picked from commit e2fa10e04d3fed4c248881d69411fc208d05ad6b) Co-authored-by: Wulian233 <1055917385@qq.com>
|
GH-148412 is a backport of this pull request to the 3.14 branch. |
|
GH-148413 is a backport of this pull request to the 3.13 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyObject_Print#148208