Skip to content

gh-148228: Enable error overlays #148229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
johnslavik wants to merge 4 commits into
base: main
Choose a base branch
from
+17 −8
Open

gh-148228: Enable error overlays #148229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
86977f9
Enable error overlays
johnslavik Apr 7, 2026
9415f6b
Fix `down` command error reporting bug
johnslavik Apr 7, 2026
62b3577
Fix `test_down_arrow_end_of_input`
johnslavik Apr 7, 2026
50188d3
Fix `test_right_arrow_end_of_line` test
johnslavik Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Lib/_colorize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,7 @@ class LiveProfiler(ThemeSection):
@dataclass(frozen=True, kw_only=True)
class Syntax(ThemeSection):
prompt: str = ANSIColors.BOLD_MAGENTA
error: str = ANSIColors.BOLD_RED
keyword: str = ANSIColors.BOLD_BLUE
keyword_constant: str = ANSIColors.BOLD_BLUE
builtin: str = ANSIColors.CYAN
Expand Down
6 changes: 4 additions & 2 deletions Lib/_pyrepl/commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,8 +289,10 @@ def do(self) -> None:
r.select_item(r.historyi + 1)
r.pos = r.eol(0)
return
r.pos = len(b)
r.error("end of buffer")
if r.pos == len(b):
r.error("end of buffer")
else:
r.pos = len(b)
return

if (
Expand Down
7 changes: 6 additions & 1 deletion Lib/_pyrepl/reader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,7 @@ class Reader:
ps3: str = "|.. "
ps4: str = R"\__ "
kill_ring: list[list[str]] = field(default_factory=list)
error_prefix: str = "! "
msg: str = ""
arg: int | None = None
dirty: bool = False
Expand Down Expand Up @@ -641,7 +642,11 @@ def finish(self) -> None:
pass

def error(self, msg: str = "none") -> None:
self.msg = "! " + msg + " "
error_prefix = self.error_prefix
if self.can_colorize:
t = THEME()
error_prefix = f"{t.error}{error_prefix}{t.reset}"
self.msg = error_prefix + msg
self.dirty = True
self.console.beep()

Expand Down
3 changes: 0 additions & 3 deletions Lib/_pyrepl/readline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,9 +124,6 @@ def __post_init__(self) -> None:
self.commands["backspace_dedent"] = backspace_dedent
self.commands["backspace-dedent"] = backspace_dedent

def error(self, msg: str = "none") -> None:
pass # don't show error messages by default

def get_stem(self) -> str:
b = self.buffer
p = self.pos - 1
Expand Down
8 changes: 6 additions & 2 deletions Lib/test/test_pyrepl/test_pyrepl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,13 +212,15 @@ def test_down_arrow_end_of_input(self):
events = itertools.chain(
code_to_events(code),
[
# Go left first to avoid end of buffer error.
Event(evt="key", data="left", raw=bytearray(b"\x1bOD")),
Event(evt="key", data="down", raw=bytearray(b"\x1bOB")),
],
)

reader, console = handle_all_events(events)
self.assertEqual(reader.cxy, (0, 2))
console.move_cursor.assert_called_once_with(0, 2)
console.move_cursor.assert_called_with(0, 2)

def test_left_arrow_simple(self):
events = itertools.chain(
Expand All @@ -236,13 +238,15 @@ def test_right_arrow_end_of_line(self):
events = itertools.chain(
code_to_events("11+11"),
[
# Go left first to avoid end of buffer error.
Event(evt="key", data="left", raw=bytearray(b"\x1bOD")),
Event(evt="key", data="right", raw=bytearray(b"\x1bOC")),
],
)

reader, console = handle_all_events(events)
self.assertEqual(reader.cxy, (5, 0))
console.move_cursor.assert_called_once_with(5, 0)
console.move_cursor.assert_called_with(5, 0)

def test_cursor_position_simple_character(self):
events = itertools.chain(code_to_events("k"))
Expand Down
Loading