Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions Lib/test/test_capi/test_opt.py
Original file line number Diff line number Diff line change
Expand Up @@ -4554,6 +4554,24 @@ def return_true():
# v + 1 should be constant folded
self.assertNotIn("_BINARY_OP", uops)

def test_is_none_narrows_to_constant(self):
def testfunc(n):
value = None
hits = 0
for _ in range(n):
if value is None:
hits += 1
return hits

res, ex = self._run_with_optimizer(testfunc, TIER2_THRESHOLD)
self.assertEqual(res, TIER2_THRESHOLD)
self.assertIsNotNone(ex)
uops = get_opnames(ex)

self.assertNotIn("_IS_NONE", uops)
self.assertIn("_GUARD_IS_NONE_POP", uops)
self.assertIn("_POP_TOP_NOP", uops)

def test_is_false_narrows_to_constant(self):
def f(n):
def return_false():
Expand Down
10 changes: 10 additions & 0 deletions Python/optimizer_bytecodes.c
Original file line number Diff line number Diff line change
Expand Up @@ -710,6 +710,16 @@ dummy_func(void) {
r = right;
}

op(_IS_NONE, (value -- b)) {
if (sym_is_const(ctx, value)) {
PyObject *value_o = sym_get_const(ctx, value);
b = sym_new_const(ctx, Py_IsNone(value_o) ? Py_True : Py_False);
}
else {
b = sym_new_type(ctx, &PyBool_Type);
}
}

op(_CONTAINS_OP, (left, right -- b, l, r)) {
b = sym_new_type(ctx, &PyBool_Type);
l = left;
Expand Down
10 changes: 9 additions & 1 deletion Python/optimizer_cases.c.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading