gh-131798: do not watch immutable types in JIT#148383
Merged
kumaraditya303 merged 4 commits intopython:mainfrom Apr 11, 2026
Merged
gh-131798: do not watch immutable types in JIT#148383kumaraditya303 merged 4 commits intopython:mainfrom
kumaraditya303 merged 4 commits intopython:mainfrom
Conversation
kumaraditya303
commented
Apr 11, 2026
cocolato
approved these changes
Apr 11, 2026
Member
|
I just merged a PR that watches more types 1c89817 I assume those don't need to be checked, as immutable types usually have no Also can you edit your PR description to explain why (e.g. reduce the chance of false positive in bloom filter). |
Contributor
Author
Immutable types does not mean that the object is immutable too, like dict so it can have
Edited. |
Member
|
Oh ok. In that case, please pull in main and do the same then. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Immutable types cannot change so there is no need to add type watcher to them and add it to bloom filter. This reduces the false positive from bloom filters.