gh-148393: Use atomic ops on _ma_watcher_tag in free threading build#148397
Merged
colesbury merged 1 commit intopython:mainfrom Apr 12, 2026
Merged
gh-148393: Use atomic ops on _ma_watcher_tag in free threading build#148397colesbury merged 1 commit intopython:mainfrom
colesbury merged 1 commit intopython:mainfrom
Conversation
…build Fixes data races between dict mutation and watch/unwatch on the same dict.
Fidget-Spinner
approved these changes
Apr 11, 2026
Member
Fidget-Spinner
left a comment
There was a problem hiding this comment.
Thanks for fixing this in the optimizer as well!
|
Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 12, 2026
…build (pythongh-148397) Fixes data races between dict mutation and watch/unwatch on the same dict. (cherry picked from commit 3ab94d684286b49144bf2e43cc1041f3e4c0cda8) Co-authored-by: Sam Gross <colesbury@gmail.com>
|
GH-148451 is a backport of this pull request to the 3.14 branch. |
colesbury
added a commit
that referenced
this pull request
Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes data races between dict mutation and watch/unwatch on the same dict.
PyDict_WatchandPyDict_Unwatchshould use atomic operations in the free threading build #148393