gh-148402: show caller's location of subprocess.Popen's warnings#148400
gh-148402: show caller's location of subprocess.Popen's warnings#148400stef41 wants to merge 2 commits intopython:mainfrom
Conversation
Both warnings.warn() calls in Popen.__init__ (one on POSIX for pass_fds overriding close_fds, one on Windows for handle_list overriding close_fds) were missing stacklevel=2. Without stacklevel=2, the warning points to an internal line in subprocess.py rather than the caller's Popen() invocation, making it harder for users to locate the source of the warning in their own code.
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
picnixz
left a comment
There was a problem hiding this comment.
Please add a regression test.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Summary
Both
warnings.warn()calls inPopen.__init__are missingstacklevel=2:pass_fdsoverridesclose_fdsstartupinfo.lpAttributeList['handle_list']overridesclose_fdsWithout
stacklevel=2, the warning message points to an internal line insidesubprocess.pyrather than the caller'sPopen()invocation, making it harder for users to locate the source of the warning in their own code.Example
Before (without stacklevel):
After (with stacklevel=2):
Changes
stacklevel=2to bothwarnings.warn()calls inPopen.__init__