bpo-34990: Change pyc headers to use 64-bit timestamps#19651
Closed
ammaraskar wants to merge 1 commit intopython:masterfrom
Closed
bpo-34990: Change pyc headers to use 64-bit timestamps#19651ammaraskar wants to merge 1 commit intopython:masterfrom
ammaraskar wants to merge 1 commit intopython:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a more permanent alternative to the
compileallissue. As Benjamin originally suggested here in the PEP 552 pull request this changes both the timestamp and size to use 64 bit integers. In the hashed pyc files, we end up padding out the space that would be used with zeroes.It is possible that I missed a few tests since the larger 8-byte field can masquerade as the two 4-byte fields easily.
As a bonus this also lets us support large source files, though I question if anyone is really compiling larger than 2/4GB python files.
https://bugs.python.org/issue34990