Skip to content

bpo-11998: Patch smtplib.py#23490

Closed
prrvchr wants to merge 1 commit intopython:3.9from
prrvchr:patch-1
Closed

bpo-11998: Patch smtplib.py#23490
prrvchr wants to merge 1 commit intopython:3.9from
prrvchr:patch-1

Conversation

@prrvchr
Copy link
Copy Markdown

@prrvchr prrvchr commented Nov 24, 2020

This update was made to meet 2 needs:

https://bugs.python.org/issue36094

This update was made to meet 2 needs:

- Bug Fix: python#11998
- Allow backward compatibility with Python 2.7.9 or higher.
@prrvchr prrvchr requested a review from a team as a code owner November 24, 2020 10:52
@the-knights-who-say-ni
Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@prrvchr

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@corona10
Copy link
Copy Markdown
Member

Python2 is EOL. We does not support Python 2.7.x

@prrvchr
Copy link
Copy Markdown
Author

prrvchr commented Nov 24, 2020

@corona10
Python 2 EOL: We will have to work with python 2.7.x for many more years ...
Why refuse to have only one version of smtplib.py to maintain ...

@jstasiak
Copy link
Copy Markdown
Contributor

I believe this should be split into two pull requests – one fixing a bug and another improving backward compatibility. Right now I can barely see what the actual fix is here.

But on the backward compatibility front:

Why refuse to have only one version of smtplib.py to maintain ...

I'd say because it may add a maintenance burden (arguably not in this case) or affect the code negatively (like initial_response_ok losing its keyword-only designation in this patch).

@prrvchr
Copy link
Copy Markdown
Author

prrvchr commented Dec 3, 2020

Ok, I drop the backward compatibility...
I corrected the bug link: https://bugs.python.org/issue36094
I create 2 files, one for python 2 and one for python 3, available on the following links:
https://github.com/prrvchr/cpython/blob/2.7/Lib/smtplib.py
https://github.com/prrvchr/cpython/blob/3.9/Lib/smtplib.py
You are free to take care to merge these changes, that in me I use these modified versions ...

@asvetlov
Copy link
Copy Markdown
Contributor

asvetlov commented Dec 4, 2020

In general, a pull request should be created against the master branch and manually backported if the automatic backpot fails.

This is the project policy.

2.7 branch is frozen and doesn't accept any change, sorry.

I'm closing this PR; it removes all audit calls which is not acceptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants