bpo-47256: re module, limit the maximum capturing group to 1,073,741,823, increasing the depth of backtracking.#32411
Merged
serhiy-storchaka merged 5 commits intomainfrom Apr 18, 2022
unknown repository
Merged
bpo-47256: re module, limit the maximum capturing group to 1,073,741,823, increasing the depth of backtracking.#32411serhiy-storchaka merged 5 commits intomainfrom unknown repository
serhiy-storchaka merged 5 commits intomainfrom
unknown repository
Conversation
Author
|
I would like to remove the variable |
Misc/NEWS.d/next/Library/2022-04-08-14-55-55.bpo-47256.X2mFpt.rst
Outdated
Show resolved
Hide resolved
Member
Do it. |
These types are kept as Py_ssize_t: - PatternObject.groups - MatchObject.lastindex - MatchObject.groups - On 32 bit platform: 36 bytes, no change. (msvc2022) - On 64 bit platform: 72 bytes -> 64 bytes. (msvc2022/gcc9.4)
change the type of `SRE(match_context).jump` from Py_ssize_t to int - On 32 bit platform: 36 bytes, no change. (msvc2022) - On 64 bit platform: 64 bytes -> 56 bytes. (msvc2022/gcc9.4) And make the order of `DO_JUMPX` macro and `SRE(match_context)` struct consistent.
DATA_STACK_(PUSH|POP) macros use the size multiple time, now computed value is propagated.
Author
|
Improved as your comments locally. |
Member
|
I have no other comments. Please update this PR. |
Author
I mean reviewer... |
serhiy-storchaka
approved these changes
Apr 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #91412.